Introduce a wayland/x11 mutter hints protocol for monitor labels #2084
+76
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2024
danirabbit
requested changes
Oct 12, 2024
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Since we're in the stable release phase we can add new API but we can't break old API until the next major version bump
Member
Author
|
Ah right that is a thing oops 😅 |
leolost2605
added
the
Blocked
Member
|
@leolost2605 is it possible to add the new API without breaking the old API so we can move forward? |
leolost2605
force-pushed
the
leolost/monitor-label-protocol
branch
from
9d7dc8b to
7861903
Compare
leolost2605
force-pushed
the
leolost/monitor-label-protocol
branch
from
7861903 to
b9da554
Compare
leolost2605
removed
Blocked
Member
Author
|
@danirabbit finally got around to updating this so it should be ready without breaking the current API :) |
leolost2605
force-pushed
the
leolost/monitor-label-protocol
branch
2 times, most recently
from
b328a49 to
b12d7b4
Compare
leolost2605
force-pushed
the
leolost/monitor-label-protocol
branch
from
b12d7b4 to
edaf1f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we do monitor labels quite awkardly. First the display plug has to go via dbus to the daemon having to send color info, monitor index, label, x, y then the daemon spawns the labels and then gala looks at the window title and positions the label.
This can be made properly now by just using a wayland protocol/ setting the mutter hints on x11.
Goes with elementary/pantheon-wayland#3 and elementary/settings-display#401